Items stack listing #233
Merged
Items stack listing #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would also like to add that this feature has been working for me for months without any issues! |
Merged
|
@Nuklon, could you please review this PR if you have time? |
Nuklon
reviewed
Dec 18, 2024
Nuklon
requested changes
Dec 19, 2024
code.user.js
Outdated
| @@ -1313,11 +1321,11 @@ | |||
| const callback = () => setTimeout(() => next(), getRandomInt(1000, 1500)); | |||
|
|
|||
| if (success) { | |||
| logDOM(`${padLeft} - ${itemName} listed for ${formatPrice(market.getPriceIncludingFees(task.sellPrice))}, you will receive ${formatPrice(task.sellPrice)}.`); | |||
| logDOM(`${padLeft} - ${itemName}${getAmountString(task.item.amount)} listed for ${formatPrice(market.getPriceIncludingFees(task.sellPrice) * task.item.amount)}, you will receive ${formatPrice(task.sellPrice * task.item.amount)}.`); | |||
There was a problem hiding this comment.
I think this would be better to have in front. In your example: 34x Hexagonana
We can probably also avoid the function, it's pretty much a one-liner, e.g. const amount = task.item.amount == 1 ? '' : task.item.amount + 'x ';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capability to list stacked items and math formulas to correctly display the price for such items.
"My Market Count" example
"Sell All" example
Unfortunately, I couldn't find a good solution to fix the ugliest line to find the amount of items.
If we take a pure HTML string, it will cause problems with items that have a number at the beginning of the name.